fix(json): quote object keys in schema output#1023
Open
CastawayEGR wants to merge 2 commits intortk-ai:developfrom
Open
fix(json): quote object keys in schema output#1023CastawayEGR wants to merge 2 commits intortk-ai:developfrom
CastawayEGR wants to merge 2 commits intortk-ai:developfrom
Conversation
Both functions formatted JSON object keys without double quotes, producing invalid JSON that broke jq, python json.load(), etc. Fixes rtk-ai#1015
pszymkowiak
added
bug
Collaborator
📊 Automated PR Analysis
SummaryFixes invalid JSON output from compact_json() and extract_schema() by wrapping object keys in double quotes. Previously, keys were emitted without quotes, breaking standard JSON parsers like jq and Python's json.load(). Review Checklist
Linked issues: #1015 Analyzed automatically by wshm · This is an automated analysis, not a human review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Object keys in
compact_json()andextract_schema()were missing double quotes, producing invalid JSON that breaksjq,python3 json.load(), etc.Wraps all key formatting in
"key":instead ofkey:.Fixes #1015