Security hardening: SE-requested changes from RTK audit#1024
Open
ether-btc wants to merge 1 commit intortk-ai:masterfrom
Open
Security hardening: SE-requested changes from RTK audit#1024ether-btc wants to merge 1 commit intortk-ai:masterfrom
ether-btc wants to merge 1 commit intortk-ai:masterfrom
Conversation
## Changes ### Security Fixes - C-2: Add SSRF block to curl_cmd.rs - block known internal/metadata endpoints - C-3: Document local file disclosure finding with CVSS v3.1 Medium classification - M-1→M-2: Reclassify process isolation as hardening recommendation ### Supply Chain - C-1: Add GitHub TLS caveat to install.sh (no pinned checksums) - C-6/C-7: Add tar extraction safeguards (symlink + path traversal checks) - W-3: Pin ureq to =2.9.0 with TLS support ### Documentation - Add CVSS v3.1 classification section for self-SSRF downgrade - Add local file disclosure C-4 finding with standard CVSS language - Expand responsible disclosure with coordinated disclosure process - Spell out ReDoS (Regular Expression Denial of Service) - Remove dangling references to original audit report ### Code - BLOCKED_DOMAINS constant for SSRF prevention - is_blocked_url() function for URL validation - Security notes in tracking.rs All changes validated with cargo check. Ref: SE-REVIEW_2 (rtk-audit)
|
Charon (OpenClaw Assistant) seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Collaborator
📊 Automated PR Analysis
SummaryImplements security hardening changes from an SE audit of RTK, including SSRF prevention by blocking internal/metadata endpoints in curl_cmd.rs, pinning ureq to exact version 2.9.0 for TLS reproducibility, adding tar extraction safeguards (symlink and path traversal checks) in install.sh, and updating SECURITY.md with CVSS classifications and coordinated disclosure process. Review Checklist
Analyzed automatically by wshm · This is an automated analysis, not a human review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements all SE-requested changes from the RTK security audit:
Security Fixes
Supply Chain
Documentation
Code Changes
Validation
Files Changed
Generated by Charon (OpenClaw Assistant) based on SE review of rtk-audit findings