fix(refacto-p1): unified cmds execution flow (+ rm dead code)

[aeppling]

Part 2 of codebase refacto

Summary

• Standardize exit code handling across all modules: Result<()> → Result with a single process::exit() in main.rs — modules
  never call process::exit() directly
• Standardize filter execution flow across commands
• Fix critical bug in runner.rs where rtk err and rtk test always exited 0 regardless of command failure
• Add exit_code_from_status() helper for passthrough commands and centralize signal handling (128+signal) in
  exit_code_from_output()

Test plan

• cargo fmt --all && cargo clippy --all-targets && cargo test — 1123 passed, 0 failed
• Zero std::process::exit() in src/cmds/ and src/core/ (verified via grep), exactly 1 in main.rs
• golangci-lint exit 1 exception preserved (lint issues → exit 0, matching old behavior)
• src/cmds/README.md updated with new Result contract, examples, and exit code tables
• Manual testing: rtk ; echo $? for success (0) and failure (non-zero) paths

[FlorianBruniaux]

Good refactor overall. Single exit point is the right call, the exit_code_from_output helper is solid. One inconsistency survived the pass (see inline). All 1123 tests pass, 9/9 CI checks green. LGTM with minor fix.

[FlorianBruniaux]

This exit_code was computed with .code().unwrap_or(1) at line 265, not with exit_code_from_output(). Signal kills on vitest return 1 instead of 128+signal, which breaks the zero-.code().unwrap_or(1) invariant the PR description claims.

One-line fix at line 265:

let exit_code = exit_code_from_output(&output, "vitest");

[FlorianBruniaux]

Good refactor. Single exit point is the right call and exit_code_from_output is solid. One thing that slipped through: vitest_cmd.rs line 265 still computes exit_code with .code().unwrap_or(1) instead of the new exit_code_from_output(&output, "vitest") helper. Signal kills on vitest will return 1 instead of 128+signal, breaking the zero-.code().unwrap_or(1) invariant the PR description claims. One-line fix, everything else looks good. All 1123 tests pass, 9/9 CI checks green.

[aeppling]

Thanks for the review @FlorianBruniaux , missing migration have been addressed in last commit