fix(ls): filter quality wrong truncation#990
Open
TropicalDog17 wants to merge 12 commits intortk-ai:developfrom
Open
fix(ls): filter quality wrong truncation#990TropicalDog17 wants to merge 12 commits intortk-ai:developfrom
TropicalDog17 wants to merge 12 commits intortk-ai:developfrom
Conversation
fix(refacto-codebase): technical docs & sub folders
…aster--components--rtk chore(master): release 0.34.2
fix(refacto): wrappers for standardization, exit codes lexer tokenizer, constants, code clean
…aster--components--rtk chore(master): release 0.34.3
|
|
Author
|
Hi @aeppling can you check this out, this is my first pr to the repo, thank you for your help |
Contributor
|
hello @TropicalDog17 , valid for me, could you remove the cargo lockfile, toml version bump and .release-please-manifest.json from this please ? This should just aim ls.rs |
c988efe to
d2ecbdb
Compare
Author
|
Yeah I've adjusted, my bad @aeppling |
aeppling
approved these changes
Apr 4, 2026
Author
|
Is it ready to merge @aeppling? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Might fixes #948
Problem: The old code split ls -la lines on whitespace and used fixed column indices (parts[4] for size, parts[8..] for filename). This broke when owner/group names contained spaces, causing the columns to shift — sizes became 0 and date/time fragments leaked into filenames.
Fix: The new parse_ls_line() function uses a regex (LS_DATE_RE) to find the date field as a stable anchor, which allow correctly parsing.
Test plan
cargo fmt --all && cargo clippy --all-targets && cargo testpassed for old and newly added tests