Skip to content

Try to identify where ice cast delays are coming from #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
charlie-foxtrot wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Try to identify where ice cast delays are coming from #551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf3adf5
add shout_delay() to stats file to see if it is growing with delay
charlie-foxtrot Apr 6, 2026
14f5ab2
add more stats outputs
charlie-foxtrot Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 102 additions & 0 deletions src/output.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,6 +484,10 @@ void process_outputs(channel_t* channel, int cur_scan_freq) {
continue;
}

if (shout_delay(icecast->shout) > 500) {
icecast->long_delay_count++;
}

int ret = shout_send(icecast->shout, channel->outputs[k].lamebuf, mp3_bytes);

if (ret != SHOUTERR_SUCCESS || shout_queuelen(icecast->shout) > MAX_SHOUT_QUEUELEN) {
Expand Down Expand Up @@ -839,6 +843,101 @@ static void output_output_overruns(FILE* f) {
fprintf(f, "\n");
}

static void output_icecast_delay(FILE* f) {
fprintf(f,
"# HELP icecast_delay_ms Milliseconds of audio data queued for sending to Icecast.\n"
"# TYPE icecast_delay_ms gauge\n");

for (int i = 0; i < device_count; i++) {
device_t* dev = devices + i;
for (int j = 0; j < dev->channel_count; j++) {
channel_t* channel = devices[i].channels + j;
for (int k = 0; k < channel->output_count; k++) {
if (channel->outputs[k].type != O_ICECAST)
continue;
icecast_data* icecast = (icecast_data*)(channel->outputs[k].data);
if (icecast->shout == NULL)
continue;
fprintf(f, "icecast_delay_ms{host=\"%s\",port=\"%d\",mount=\"%s\"}\t%d\n", icecast->hostname, icecast->port, icecast->mountpoint, shout_delay(icecast->shout));
}
}
}
for (int i = 0; i < mixer_count; i++) {
mixer_t* mixer = mixers + i;
for (int k = 0; k < mixer->channel.output_count; k++) {
if (mixer->channel.outputs[k].type != O_ICECAST)
continue;
icecast_data* icecast = (icecast_data*)(mixer->channel.outputs[k].data);
if (icecast->shout == NULL)
continue;
fprintf(f, "icecast_delay_ms{host=\"%s\",port=\"%d\",mount=\"%s\"}\t%d\n", icecast->hostname, icecast->port, icecast->mountpoint, shout_delay(icecast->shout));
}
}
fprintf(f, "\n");
}

static void output_icecast_queuelen(FILE* f) {
fprintf(f,
"# HELP icecast_queuelen_bytes Bytes queued in libshout send buffer.\n"
"# TYPE icecast_queuelen_bytes gauge\n");

for (int i = 0; i < device_count; i++) {
device_t* dev = devices + i;
for (int j = 0; j < dev->channel_count; j++) {
channel_t* channel = devices[i].channels + j;
for (int k = 0; k < channel->output_count; k++) {
if (channel->outputs[k].type != O_ICECAST)
continue;
icecast_data* icecast = (icecast_data*)(channel->outputs[k].data);
if (icecast->shout == NULL)
continue;
fprintf(f, "icecast_queuelen_bytes{host=\"%s\",port=\"%d\",mount=\"%s\"}\t%zu\n", icecast->hostname, icecast->port, icecast->mountpoint, shout_queuelen(icecast->shout));
}
}
}
for (int i = 0; i < mixer_count; i++) {
mixer_t* mixer = mixers + i;
for (int k = 0; k < mixer->channel.output_count; k++) {
if (mixer->channel.outputs[k].type != O_ICECAST)
continue;
icecast_data* icecast = (icecast_data*)(mixer->channel.outputs[k].data);
if (icecast->shout == NULL)
continue;
fprintf(f, "icecast_queuelen_bytes{host=\"%s\",port=\"%d\",mount=\"%s\"}\t%zu\n", icecast->hostname, icecast->port, icecast->mountpoint, shout_queuelen(icecast->shout));
}
}
fprintf(f, "\n");
}

static void output_icecast_long_delay(FILE* f) {
fprintf(f,
"# HELP icecast_long_delay_count Number of times shout_delay exceeded 500ms before sending.\n"
"# TYPE icecast_long_delay_count counter\n");

for (int i = 0; i < device_count; i++) {
device_t* dev = devices + i;
for (int j = 0; j < dev->channel_count; j++) {
channel_t* channel = devices[i].channels + j;
for (int k = 0; k < channel->output_count; k++) {
if (channel->outputs[k].type != O_ICECAST)
continue;
icecast_data* icecast = (icecast_data*)(channel->outputs[k].data);
fprintf(f, "icecast_long_delay_count{host=\"%s\",port=\"%d\",mount=\"%s\"}\t%zu\n", icecast->hostname, icecast->port, icecast->mountpoint, icecast->long_delay_count);
}
}
}
for (int i = 0; i < mixer_count; i++) {
mixer_t* mixer = mixers + i;
for (int k = 0; k < mixer->channel.output_count; k++) {
if (mixer->channel.outputs[k].type != O_ICECAST)
continue;
icecast_data* icecast = (icecast_data*)(mixer->channel.outputs[k].data);
fprintf(f, "icecast_long_delay_count{host=\"%s\",port=\"%d\",mount=\"%s\"}\t%zu\n", icecast->hostname, icecast->port, icecast->mountpoint, icecast->long_delay_count);
}
}
fprintf(f, "\n");
}

static void output_input_overruns(FILE* f) {
if (mixer_count == 0) {
return;
Expand Down Expand Up @@ -889,6 +988,9 @@ void write_stats_file(timeval* last_stats_write) {
output_channel_flappy_counter(file);
output_channel_ctcss_counter(file);
output_channel_no_ctcss_counter(file);
output_icecast_delay(file);
output_icecast_queuelen(file);
output_icecast_long_delay(file);
output_device_buffer_overflows(file);
output_output_overruns(file);
output_input_overruns(file);
Expand Down
1 change: 1 addition & 0 deletions src/rtl_airband.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ struct icecast_data {
const char* genre;
const char* description;
bool send_scan_freq_tags;
size_t long_delay_count;
shout_t* shout;
};

Expand Down
Loading