Sherman Morrison Method for Implicit Solvers#273
Open
psv4 wants to merge 5 commits intortqichen:masterfrom
Open
Sherman Morrison Method for Implicit Solvers#273psv4 wants to merge 5 commits intortqichen:masterfrom
psv4 wants to merge 5 commits intortqichen:masterfrom
Conversation
Move GL4 tableau closer to definition Change Implicit Trapezoid to DIRK solver
Contributor
Author
Tests |
commit 0d38c2f Author: psv4 <[email protected]> Date: Wed Dec 3 11:23:08 2025 -0500 Cleaned up with super commit 4cd4c6a Author: psv4 <[email protected]> Date: Fri Nov 21 17:48:08 2025 -0500 Variable tolerance commit 66255de Author: psv4 <[email protected]> Date: Tue Nov 18 18:51:41 2025 -0500 Sparse update
Contributor
Author
|
@rtqichen this was a bigger update. For my work, the Jacobian inverse would take too much memory if it were dense. Following this paper, I switched it to sparse and it can actually run faster now. Additionally, cleaned up the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #267 and Closes #214 .
Replaces the costly Jacobian inverse calculation for implicit solvers with the good Sherman-Morrison method.
Additionally, reorders the tableau for GL4 to be closer to its definition and switches the implicit trapezoid method to use the DIRK solver.