Fix hotkeys in macOS#91
Open
pedrogxv wants to merge 14 commits into
Open
Conversation
This reverts commit 9f6f89c.
There was a problem hiding this comment.
Pull request overview
This PR aims to fix macOS hotkey detection and make the Settings dialog present macOS-appropriate modifier key labels while keeping the stored hotkey format consistent for the input layer.
Changes:
- Updated macOS hotkey detection to use Quartz global HID modifier flags and normalized modifier parsing.
- Updated the Settings dialog hotkey selector to use platform-specific labels/userData pairs and normalize persisted hotkey values.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/meikipop/gui/settings_dialog.py |
Adds hotkey normalization and macOS-specific hotkey option labels in the settings UI; persists normalized hotkey values. |
src/meikipop/gui/input.py |
Refactors macOS modifier parsing and hotkey detection to use Quartz modifier flags for cross-app detection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
thanks for the PR. i will have a look but it may take a few weeks. i'd first like to wrap up the wayland merge request if possible, do a v2 release and then let some time pass to see if anyone is reporting issues before piling on more changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifications
Motivation
Hello, this PR was created to address a bug in the mac application where we could not use others keybinds, even when changing the settings of the hotkey to use "alt" or "cmd".
The second problem was that the front-end of the GUI was not handling the available keys in the apple keyboard (option, command and etc), this was also a target in this PR and now it must be solved.
I can provide more information of the bug by recording some tests before and after if you may find necessary.
I also found positive to do a little code cleaning in the gui section, taking this new approach for mac keyboards in consideration.
That's it, thanks.