Add 3MF file format support (#60)#81
Open
trek-e wants to merge 3 commits intorubenwe:masterfrom
Open
Conversation
- STACK.md - Technologies and dependencies - ARCHITECTURE.md - System design and patterns - STRUCTURE.md - Directory layout - CONVENTIONS.md - Code style and patterns - TESTING.md - Test structure - INTEGRATIONS.md - External services - CONCERNS.md - Technical debt and issues
- Add ObjParser for parsing Wavefront OBJ files - Create unified MeshImporter that handles STL and OBJ formats - Update Constants to support multiple file patterns (*.stl, *.obj) - Update IFileSystem/FolderFileSystem to support multiple patterns - Update Library and ViewPort to use new MeshImporter OBJ parser supports: - Vertex positions (v) - Vertex normals (vn) - Face definitions with various formats (f v, f v/vt, f v/vt/vn, f v//vn) - Polygon triangulation (fan triangulation for n-gons) - Coordinate system conversion (right-handed to Unity's left-handed) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Add ThreeMfParser for parsing 3D Manufacturing Format files - Update MeshImporter to handle .3mf extension - Add *.3mf to SupportedFilePatterns 3MF parser features: - Reads ZIP-based 3MF archives - Parses XML model data from 3D/3dmodel.model - Extracts vertices and triangles from all mesh objects - Combines multiple meshes into single model (simplest approach) - Handles namespaced and non-namespaced XML variants - Converts coordinate system (right-handed to Unity left-handed) Design decision: Single 3MF file = single combined model This matches the existing behavior where one file = one library entry. Co-Authored-By: Claude Opus 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Note: This PR depends on #80 (OBJ import) for the shared
MeshImporterinfrastructure.Changes
Assets/Scripts/Util/Mesh/ThreeMfParser.cs- Parses 3MF formatMeshImporter.cs- Added.3mfextension handlingConstants.cs- Added*.3mfto supported patterns3MF Parser Features
3D/3dmodel.modelDesign Decision
Single 3MF file = single combined model
The issue notes that 3MF can contain multiple models with transformations. For this initial implementation, I chose the simplest approach:
Future enhancements could add:
Test plan
🤖 Generated with Claude Code