Security: Fix critical null pointer dereference in ConfigStore#89
Open
trek-e wants to merge 2 commits intorubenwe:masterfrom
Open
Security: Fix critical null pointer dereference in ConfigStore#89trek-e wants to merge 2 commits intorubenwe:masterfrom
trek-e wants to merge 2 commits intorubenwe:masterfrom
Conversation
- STACK.md - Technologies and dependencies - ARCHITECTURE.md - System design and patterns - STRUCTURE.md - Directory layout - CONVENTIONS.md - Code style and patterns - TESTING.md - Test structure - INTEGRATIONS.md - External services - CONCERNS.md - Technical debt and issues
ZipFile.GetEntry() can return null if the entry doesn't exist in the archive. The code was calling .Open() directly on the result without checking for null first, which would cause a NullReferenceException. This fix adds a null check and throws a descriptive FileNotFoundException if the entry is missing, which is then properly handled by the outer catch block. Co-Authored-By: Claude Opus 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConfigStore.csZipFile.GetEntry()can return null if the entry doesn't exist, but the code was calling.Open()directly on the resultNullReferenceExceptioncrash when loading a corrupted or tampered config archiveSecurity Impact
Fix
Added null check before calling
Open()on the ZipArchiveEntry. If the entry is missing, a descriptiveFileNotFoundExceptionis thrown which is handled by the existing error handling.Test plan
🤖 Generated with Claude Code