Security: Fix integer overflow in BinaryStl parser#91
Open
trek-e wants to merge 2 commits intorubenwe:masterfrom
Open
Security: Fix integer overflow in BinaryStl parser#91trek-e wants to merge 2 commits intorubenwe:masterfrom
trek-e wants to merge 2 commits intorubenwe:masterfrom
Conversation
- STACK.md - Technologies and dependencies - ARCHITECTURE.md - System design and patterns - STRUCTURE.md - Directory layout - CONVENTIONS.md - Code style and patterns - TESTING.md - Test structure - INTEGRATIONS.md - External services - CONCERNS.md - Technical debt and issues
The binary STL parser had several security issues: 1. Integer overflow in `usedCount * 50` calculation when facet count is large 2. No validation for minimum file size before reading 3. No limit on facet count to prevent memory exhaustion This fix adds: - Maximum facet count limit (10 million) to prevent memory exhaustion - Minimum file size validation - Long arithmetic to prevent integer overflow in size calculations - Null checks for input arrays - Constants for magic numbers (FacetSize, HeaderSize) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BinaryStl.csusedCount * 50could overflow when facet count is very large (> ~85 million)Security Impact
Changes
Test plan
🤖 Generated with Claude Code