Skip to content

Conversation

@malmckay
Copy link

@malmckay malmckay commented Oct 30, 2025

We had **/, to support directories nested within engines or packwerk dirs This also matched against directory names above the project Adding ../ scopes the glob to the project directory, and making the whole ../**/ optional supports relative paths.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@malmckay malmckay marked this pull request as draft October 30, 2025 12:56
We had **/, to support directories nested within engines or packwerk dirs
This also matched against directory names outside the project
Adding ../ scopes the glob to the project directory
@malmckay malmckay marked this pull request as ready for review October 30, 2025 13:24
@malmckay malmckay marked this pull request as draft October 30, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant