Skip to content

Conversation

OuYangJinTing
Copy link
Contributor

Introduced a new section in the README to document for introduction of Grape::Entity::Preloader

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Let's put this in the right section of the README?

README.md Outdated

$ gem install grape-entity

## N plus one operation solution
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just call this Preloading Associations and move it up above "Caveats"?

Suggested change
## N plus one operation solution
### Preloading Associations

README.md Outdated

## N plus one operation solution

[Grape::Entity::Preloader](https://github.com/OuYangJinTing/grape-entity-preloader) allows preload associations and callbacks for avoiding N+1 operations in Grape::Entity.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Grape::Entity::Preloader](https://github.com/OuYangJinTing/grape-entity-preloader) allows preload associations and callbacks for avoiding N+1 operations in Grape::Entity.
Use [Grape::Entity::Preloader](https://github.com/OuYangJinTing/grape-entity-preloader) to preload associations and callbacks and avoid N+1 operations.

OuYangJinTing

This comment was marked as outdated.

@OuYangJinTing OuYangJinTing force-pushed the n-plus-one-operation-solution branch from d5d999f to 9120449 Compare October 14, 2025 10:05
@OuYangJinTing
Copy link
Contributor Author

@dblock Thank. I have readjusted the copy.

@dblock dblock merged commit 8f962de into ruby-grape:master Oct 14, 2025
6 checks passed
@dblock
Copy link
Member

dblock commented Oct 14, 2025

Thanks, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants