Stop auto_visibility_timeout breaking on short visibility timeouts#1021
Draft
mensfeld wants to merge 3 commits into
Draft
Stop auto_visibility_timeout breaking on short visibility timeouts#1021mensfeld wants to merge 3 commits into
mensfeld wants to merge 3 commits into
Conversation
AutoExtendVisibility scheduled its TimerTask at visibility_timeout - EXTEND_UPFRONT_SECONDS (5s). When the queue's visibility timeout was <= 5s that interval was <= 0, so TimerTask#initialize raised ArgumentError before the worker ran - every message failed and was reprocessed (re-failing) until it hit a DLQ. The extension interval is now clamped to half the visibility timeout when it would be non-positive, so the timer still fires before the message becomes visible again. The extension is skipped with a clear warning only when the visibility timeout is <= 0. Either way the worker now always runs. Coverage: - integration spec with a 5s visibility timeout and an auto_visibility_timeout worker, asserting the message is processed (pre-fix it never was - processing crashed before the worker) - unit specs that a too-short timeout runs the worker instead of raising, and a zero timeout warns and skips the extension
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoExtendVisibility scheduled its TimerTask at
visibility_timeout - EXTEND_UPFRONT_SECONDS (5s). When the queue's visibility timeout was <= 5s that interval was <= 0, so TimerTask#initialize raised ArgumentError before the worker ran - every message failed and was reprocessed (re-failing) until it hit a DLQ.
The extension interval is now clamped to half the visibility timeout when it would be non-positive, so the timer still fires before the message becomes visible again. The extension is skipped with a clear warning only when the visibility timeout is <= 0. Either way the worker now always runs.
Coverage: