Fix busy-processor counter leak when the executor rejects a worker post#1029
Draft
mensfeld wants to merge 1 commit into
Draft
Fix busy-processor counter leak when the executor rejects a worker post#1029mensfeld wants to merge 1 commit into
mensfeld wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Manager#assign increments @busy_processors before posting the worker Promise, but the matching decrement (processor_done) runs *inside* the promise body. When the executor rejects the post (Concurrent::RejectedExecutionError) - a hard stop racing the running? check, or a saturated bounded custom launcher_executor - the body never runs and the counter leaks. With a bounded executor the leak is permanent: ready (@max_processors - busy) shrinks until dispatch stalls and the group silently stops processing. Roll back the increment on RejectedExecutionError, decrementing directly (the message was never processed, so the FIFO message_processed callback must not run).
mensfeld
force-pushed
the
fix/b3-busy-counter-leak
branch
from
57de224 to
30d31f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manager#assign increments @busy_processors before posting the worker Promise, but the matching decrement (processor_done) runs inside the promise body. When the executor rejects the post
(Concurrent::RejectedExecutionError) - a hard stop racing the running? check, or a saturated bounded custom launcher_executor - the body never runs and the counter leaks. With a bounded executor the leak is permanent: ready (@max_processors - busy) shrinks until dispatch stalls and the group silently stops processing.
Roll back the increment on RejectedExecutionError, decrementing directly (the message was never processed, so the FIFO message_processed callback must not run).