Use long polling in sqs CLI find_all so dump/mv don't stop early#1032
Draft
mensfeld wants to merge 1 commit into
Draft
Use long polling in sqs CLI find_all so dump/mv don't stop early#1032mensfeld wants to merge 1 commit into
mensfeld wants to merge 1 commit into
Conversation
find_all (used by sqs dump and sqs mv, both defaulting --number to Float::INFINITY) terminated on the first empty receive_message response. With the default short polling, SQS samples only a subset of its hosts and routinely returns an empty batch while the queue still has messages, so on real (distributed) SQS dump/mv quietly processed only a fraction of the queue (invisible on single-node LocalStack). Long poll (wait_time_seconds) and only stop after several consecutive empty batches, so the queue is actually drained. (No spec: exercising bin/cli in-process defines Shoryuken::CLI, and Shoryuken#server? is defined?(Shoryuken::CLI), which would flip server? globally and break other specs - same constraint as the CLI fix in the message_size PR.)
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find_all (used by sqs dump and sqs mv, both defaulting --number to Float::INFINITY) terminated on the first empty receive_message response. With the default short polling, SQS samples only a subset of its hosts and routinely returns an empty batch while the queue still has messages, so on real (distributed) SQS dump/mv quietly processed only a fraction of the queue (invisible on single-node LocalStack).
Long poll (wait_time_seconds) and only stop after several consecutive empty batches, so the queue is actually drained.
(No spec: exercising bin/cli in-process defines Shoryuken::CLI, and Shoryuken#server? is defined?(Shoryuken::CLI), which would flip server? globally and break other specs - same constraint as the CLI fix in the message_size PR.)