Reset all registered CurrentAttributes after each job, not just prese…#1034
Draft
mensfeld wants to merge 1 commit into
Draft
Reset all registered CurrentAttributes after each job, not just prese…#1034mensfeld wants to merge 1 commit into
mensfeld wants to merge 1 commit into
Conversation
…nt keys Loading#perform only reset the CurrentAttributes classes whose key was present in the message. A message without a cattr key - enqueued before persist was configured, by a different producer, or with an empty context - left the registered class unreset, so a value set during one job could leak into the next job on a reused worker thread (CurrentAttributes are thread-local and Shoryuken reuses pool threads). Reset every registered class in the ensure regardless of which keys the message carried. Covered by an integration spec (process-isolated, where the CurrentAttributes adapter is loaded) that enqueues two keyless jobs and asserts the second doesn't observe the first's context.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nt keys
Loading#perform only reset the CurrentAttributes classes whose key was present in the message. A message without a cattr key - enqueued before persist was configured, by a different producer, or with an empty context
Reset every registered class in the ensure regardless of which keys the message carried. Covered by an integration spec (process-isolated, where the CurrentAttributes adapter is loaded) that enqueues two keyless jobs and asserts the second doesn't observe the first's context.