Drain in-flight concurrent ActiveJob sends on launcher shutdown#1035
Draft
mensfeld wants to merge 1 commit into
Draft
Drain in-flight concurrent ActiveJob sends on launcher shutdown#1035mensfeld wants to merge 1 commit into
mensfeld wants to merge 1 commit into
Conversation
The ShoryukenConcurrentSendAdapter enqueues by scheduling the SQS send on a background future and returning immediately, so jobs enqueued shortly before the process exits (e.g. by a worker during processing) could be silently dropped. PR #1018 added ShoryukenConcurrentSendAdapter#wait_for_pending_sends to drain them, but nothing called it during Shoryuken's own shutdown. Launcher#stop and #stop! now drain the configured ActiveJob adapter after the executor has shut down (so all worker-initiated sends have been issued), bounded by Shoryuken.options[:timeout]. The call is duck-typed and guarded: it is a no-op unless ActiveJob is loaded and its adapter responds to wait_for_pending_sends, and any error is swallowed so a draining hiccup can't break shutdown.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ShoryukenConcurrentSendAdapter enqueues by scheduling the SQS send on a background future and returning immediately, so jobs enqueued shortly before the process exits (e.g. by a worker during processing) could be silently dropped. PR #1018 added ShoryukenConcurrentSendAdapter#wait_for_pending_sends to drain them, but nothing called it during Shoryuken's own shutdown.
Launcher#stop and #stop! now drain the configured ActiveJob adapter after the executor has shut down (so all worker-initiated sends have been issued), bounded by Shoryuken.options[:timeout]. The call is duck-typed and guarded: it is a no-op unless ActiveJob is loaded and its adapter responds to wait_for_pending_sends, and any error is swallowed so a draining hiccup can't break shutdown.