Log partial batch-send failures instead of swallowing them#1037
Draft
mensfeld wants to merge 1 commit into
Draft
Log partial batch-send failures instead of swallowing them#1037mensfeld wants to merge 1 commit into
mensfeld wants to merge 1 commit into
Conversation
Queue#send_messages returned the SendMessageBatchResult but never looked at response.failed. SQS reports per-entry batch failures there (throttling, oversize/malformed entries, or a same-batch duplicate dedup id) rather than raising, so they vanished silently - most importantly via ShoryukenAdapter#enqueue_all, which reads only response.successful and even marks the dropped jobs successfully_enqueued. Log each failed entry, mirroring delete_messages. enqueue_all (which calls send_messages) now surfaces them too. The response is still returned unchanged for callers that inspect it.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queue#send_messages returned the SendMessageBatchResult but never looked at response.failed. SQS reports per-entry batch failures there (throttling, oversize/malformed entries, or a same-batch duplicate dedup id) rather than raising, so they vanished silently - most importantly via ShoryukenAdapter#enqueue_all, which reads only response.successful and even marks the dropped jobs successfully_enqueued.
Log each failed entry, mirroring delete_messages. enqueue_all (which calls send_messages) now surfaces them too. The response is still returned unchanged for callers that inspect it.