Skip to content

Initialze SSL to the proxy independent of proxied connection SSL mode #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions lib/net/http.rb
Original file line number Diff line number Diff line change
Expand Up @@ -1664,15 +1664,15 @@ def connect
}
s.setsockopt(Socket::IPPROTO_TCP, Socket::TCP_NODELAY, 1)
debug "opened"

if proxy? && @proxy_use_ssl
s = OpenSSL::SSL::SSLSocket.new(s)
ssl_socket_connect(s, @open_timeout)
end

if use_ssl?
if proxy?
if @proxy_use_ssl
proxy_sock = OpenSSL::SSL::SSLSocket.new(s)
ssl_socket_connect(proxy_sock, @open_timeout)
else
proxy_sock = s
end
proxy_sock = BufferedIO.new(proxy_sock, read_timeout: @read_timeout,
proxy_sock = BufferedIO.new(s, read_timeout: @read_timeout,
write_timeout: @write_timeout,
continue_timeout: @continue_timeout,
debug_output: @debug_output)
Expand Down
46 changes: 45 additions & 1 deletion test/net/http/test_https_proxy.rb
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def read_fixture(key)
File.read(File.expand_path("../fixtures/#{key}", __dir__))
end

def test_https_proxy_ssl_connection
def test_https_proxy_ssl_connection_tunneled_https
begin
OpenSSL
rescue LoadError
Expand Down Expand Up @@ -91,4 +91,48 @@ def test_https_proxy_ssl_connection
assert_join_threads([client_thread, server_thread])
}
end

def test_https_proxy_ssl_connection_tunneled_http
begin
OpenSSL
rescue LoadError
omit 'autoload problem. see [ruby-dev:45021][Bug #5786]'
end

TCPServer.open("127.0.0.1", 0) {|tcpserver|
ctx = OpenSSL::SSL::SSLContext.new
ctx.key = OpenSSL::PKey.read(read_fixture("server.key"))
ctx.cert = OpenSSL::X509::Certificate.new(read_fixture("server.crt"))
serv = OpenSSL::SSL::SSLServer.new(tcpserver, ctx)

_, port, _, _ = serv.addr
client_thread = Thread.new {
proxy = Net::HTTP.Proxy("127.0.0.1", port, 'user', 'password', true)
http = proxy.new("foo.example.org", 8000)
begin
http.start
http.get('/')
rescue OpenSSL::SSL::SSLError
end
}
server_thread = Thread.new {
sock = serv.accept
begin
proxy_request = sock.gets("\r\n\r\n")
assert_equal(
"GET http://foo.example.org:8000/ HTTP/1.1\r\n" +
"Accept-Encoding: gzip;q=1.0,deflate;q=0.6,identity;q=0.3\r\n" +
"Accept: */*\r\n" +
"User-Agent: Ruby\r\n" +
"Proxy-Authorization: Basic dXNlcjpwYXNzd29yZA==\r\n" +
"Host: foo.example.org:8000\r\n" +
"\r\n",
proxy_request)
ensure
sock.close
end
}
assert_join_threads([client_thread, server_thread])
}
end
end if defined?(OpenSSL)