Add benchmarks for various Addressable URI operations #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to track the performance of common operations in the Addressable gem, such as parsing, normalization, component access, and modification. We heavily use the Addressable gem in our projects, so having benchmarks will help us monitor performance changes over time and ensure that updates to the gem or our codebase do not introduce regressions.
tekknolagi
approved these changes
Nov 15, 2025
eregon
reviewed
Nov 17, 2025
| public_suffix (6.0.2) | ||
|
|
||
| PLATFORMS | ||
| aarch64-linux |
Member
There was a problem hiding this comment.
I guess that's more of a Bundler thing/issue, but I wonder why the architecture is even included here given those are pure-Ruby gems.
Collaborator
Author
There was a problem hiding this comment.
AFAIK, that is the default behavior of bundler. It always include the architecture where the gemfile was created
tekknolagi
force-pushed
the
rmf-add-benchmark
branch
from
12d4049 to
cc305e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to track the performance of common operations in the Addressable gem, such as parsing, normalization, component access, and modification.
We heavily use the Addressable gem in our projects, so having benchmarks will help us monitor performance changes over time and ensure that updates to the gem or our codebase do not introduce regressions.