Skip to content

feat: upgrade to node 24 #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2025
Merged

feat: upgrade to node 24 #804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c64fa50
feat: upgrade to node 24
chenrui333 Sep 16, 2025
a402258
chore: add setup-node for lint job
chenrui333 Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,9 @@ jobs:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v5
- uses: actions/setup-node@v5
with:
node-version: '24'
- run: yarn install
- run: yarn run package
- name: Check generated files are up to date
Expand Down
2 changes: 1 addition & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,5 +49,5 @@ outputs:
ruby-prefix:
description: 'The prefix of the installed ruby'
runs:
using: 'node20'
using: 'node24'
main: 'dist/index.js'
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
"version": "0.1.0",
"description": "Download a prebuilt Ruby and add it to the PATH in 5 seconds",
"main": "index.js",
"engines": {
"node": ">=24.0.0"
},
Comment on lines +6 to +8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this achieve? Force actually using node 24+?
I'm not sure of the value, besides finding that the lint job was using an older node.

Also IIRC there is some env var or config for runners to ignore the using: 'node24' directive, I don't necessarily want to prevent using that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just matches with node24 in action.yml (yeah, it would force the runner to be upgraded)

Also IIRC there is some env var or config for runners to ignore the using: 'node24' directive, I don't necessarily want to prevent using that.

I dont think I ever saw it before

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically this engine constraint should be there before too (but I guess setup-* actions are just adding this time)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be ACTIONS_RUNNER_FORCE_ACTIONS_NODE_VERSION (actions/runner#1911).
I suspect this change will break if someone uses that to force running an older node.
But, we can try and easily revert it if necessary.

"license": "MIT",
"scripts": {
"package": "ncc build index.js -o dist"
Expand Down
Loading