Reinstate testing against jruby 9.4 and head #807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f2f42b7.
In general the de-facto rule so far was to only test latest release for non-CRuby, but this seems a good enough argument, let's do it, at least for now and while it doesn't cause issues. |
mergify bot
added a commit
to robfrank/linklift
that referenced
this pull request
Sep 24, 2025
Bumps the github-actions group with 2 updates: [graalvm/setup-graalvm](https://github.com/graalvm/setup-graalvm) and [ruby/setup-ruby](https://github.com/ruby/setup-ruby). Updates `graalvm/setup-graalvm` from 1.3.6 to 1.3.7 Release notes *Sourced from [graalvm/setup-graalvm's releases](https://github.com/graalvm/setup-graalvm/releases).* > v1.3.7 > ------ > > What's Changed > -------------- > > * Bump actions/checkout from 4 to 5 by [`@dependabot`](https://github.com/dependabot)[bot] in [graalvm/setup-graalvm#179](https://redirect.github.com/graalvm/setup-graalvm/pull/179) > * Bump the npm-development group across 1 directory with 9 updates by [`@dependabot`](https://github.com/dependabot)[bot] in [graalvm/setup-graalvm#180](https://redirect.github.com/graalvm/setup-graalvm/pull/180) > * Revise `dependabot.yml` and pin GitHub Actions. by [`@fniephaus`](https://github.com/fniephaus) in [graalvm/setup-graalvm#181](https://redirect.github.com/graalvm/setup-graalvm/pull/181) > * Test against GraalVM 25 and update `README.md`. by [`@fniephaus`](https://github.com/fniephaus) in [graalvm/setup-graalvm#183](https://redirect.github.com/graalvm/setup-graalvm/pull/183) > > **Full Changelog**: <graalvm/setup-graalvm@v1...v1.3.7> Commits * [`aba6a07`](graalvm/setup-graalvm@aba6a07) Bump version to `1.3.7`. * [`f4710e5`](graalvm/setup-graalvm@f4710e5) Update `README.md` for GraalVM 25. * [`1513e54`](graalvm/setup-graalvm@1513e54) Test against GraalVM 25 and 26 EA builds. * [`ba5bc86`](graalvm/setup-graalvm@ba5bc86) Pin GitHub Actions. * [`2fea119`](graalvm/setup-graalvm@2fea119) Revise `dependabot.yml`. * [`deee6c3`](graalvm/setup-graalvm@deee6c3) Address new eslint warning. * [`eb8ac6d`](graalvm/setup-graalvm@eb8ac6d) Bump the npm-development group across 1 directory with 9 updates * [`7e60c93`](graalvm/setup-graalvm@7e60c93) Bump actions/checkout from 4 to 5 * See full diff in [compare view](graalvm/setup-graalvm@7a1da54...aba6a07) Updates `ruby/setup-ruby` from 1.257.0 to 1.262.0 Release notes *Sourced from [ruby/setup-ruby's releases](https://github.com/ruby/setup-ruby/releases).* > v1.262.0 > -------- > > **Full Changelog**: <ruby/setup-ruby@v1.261.0...v1.262.0> > > v1.261.0 > -------- > > What's Changed > -------------- > > * Update CRuby releases on Windows by [`@ruby-builder-bot`](https://github.com/ruby-builder-bot) in [ruby/setup-ruby#809](https://redirect.github.com/ruby/setup-ruby/pull/809) > > **Full Changelog**: <ruby/setup-ruby@v1.260.0...v1.261.0> > > v1.260.0 > -------- > > What's Changed > -------------- > > * Revert "feat: upgrade to node 24" by [`@eregon`](https://github.com/eregon) in [ruby/setup-ruby#808](https://redirect.github.com/ruby/setup-ruby/pull/808) > * Reinstate testing against jruby 9.4 and head by [`@chadlwilson`](https://github.com/chadlwilson) in [ruby/setup-ruby#807](https://redirect.github.com/ruby/setup-ruby/pull/807) > > New Contributors > ---------------- > > * [`@chadlwilson`](https://github.com/chadlwilson) made their first contribution in [ruby/setup-ruby#807](https://redirect.github.com/ruby/setup-ruby/pull/807) > > **Full Changelog**: <ruby/setup-ruby@v1.259.0...v1.260.0> > > v1.259.0 > -------- > > What's Changed > -------------- > > * feat: upgrade to node 24 by [`@chenrui333`](https://github.com/chenrui333) in [ruby/setup-ruby#804](https://redirect.github.com/ruby/setup-ruby/pull/804) > > **Full Changelog**: <ruby/setup-ruby@v1.258.0...v1.259.0> > > v1.258.0 > -------- > > What's Changed > -------------- > > * Add ruby-3.4.6 by [`@ruby-builder-bot`](https://github.com/ruby-builder-bot) in [ruby/setup-ruby#802](https://redirect.github.com/ruby/setup-ruby/pull/802) > * Add truffleruby-25.0.0,truffleruby+graalvm-25.0.0 by [`@ruby-builder-bot`](https://github.com/ruby-builder-bot) in [ruby/setup-ruby#803](https://redirect.github.com/ruby/setup-ruby/pull/803) > > **Full Changelog**: <ruby/setup-ruby@v1.257.0...v1.258.0> Commits * [`cf7216d`](ruby/setup-ruby@cf7216d) Use new releases of ruby-builder per engine-version * [`1c58d16`](ruby/setup-ruby@1c58d16) Update CRuby releases on Windows * [`1dc7956`](ruby/setup-ruby@1dc7956) Test on JRuby 9.4 as well as 10.0 * [`b8714f7`](ruby/setup-ruby@b8714f7) Revert "Skip test failing on JRuby on Windows" * [`d3e13b3`](ruby/setup-ruby@d3e13b3) Revert "feat: upgrade to node 24" * [`4df093a`](ruby/setup-ruby@4df093a) Revert "chore: add setup-node for lint job" * [`866b91c`](ruby/setup-ruby@866b91c) chore: add setup-node for lint job * [`c4cd38d`](ruby/setup-ruby@c4cd38d) feat: upgrade to node 24 * [`3fee676`](ruby/setup-ruby@3fee676) Add truffleruby-25.0.0,truffleruby+graalvm-25.0.0 * [`c61fbf1`](ruby/setup-ruby@c61fbf1) Add ruby-3.4.6 * See full diff in [compare view](ruby/setup-ruby@4451173...cf7216d) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore ` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore ` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore ` will remove the ignore condition of the specified dependency and ignore conditions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jrubywas testing 9.4 andjruby-headwas testing 10.0)If you're not comfortable adding yet more jobs, can reconsider adding 9.4. Having said that, given the significant changes and major Java version increase, possibly wise to test both given they are both supported.