Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add new Ruby versions (3.3, 3.4, some windows), use actions/checkout@v4 #15

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

MSP-Greg
Copy link
Contributor

No description provided.

@simi simi merged commit f32ce12 into rubygems:master Jan 11, 2025
23 checks passed
@simi
Copy link
Member

simi commented Jan 11, 2025

Thanks @MSP-Greg.

@MSP-Greg
Copy link
Contributor Author

@simi

Thanks for the quick merge. I ended up looking here from an issue in RG, what do you think about adding something like the file mentioned in:

rubygems/rubygems#8390 (comment)
The file is:
https://github.com/MSP-Greg/ruby-ssl-check/blob/00-ssl-code/ssl_connect.rb

I work with the three main OS's, and I don't recall ever having ssl issues. I'm using Ruby master on all three also. When people have the http test here failing, I have no idea what the issue might be.

Maybe the cert store, we could some minimal tests of it? Not sure...

@MSP-Greg MSP-Greg deleted the 00-ci branch January 11, 2025 19:54
@simi
Copy link
Member

simi commented Jan 11, 2025

@MSP-Greg per my understanding net/http is using openssl also. But if there's any test in your script missing in current check.rb, feel free to update check.rb to add it.

@MSP-Greg
Copy link
Contributor Author

@simi

per my understanding net/http is using openssl also

Same here. I was just hoping (possibly incorrectly) that dropping to the socket level might provide better error messages.

I work with Puma, and net/http understandably won't allow one to create invalid requests. Hence, a lot of test code runs at the socket level...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants