chore: update google ads api version from 17 to 18 (#4084)

rudderlabs · Feb 20, 2025 · fb5bedc · fb5bedc
1 parent 58738ba
commit fb5bedc
Show file tree

Hide file tree

Showing 19 changed files with 100 additions and 118 deletions.
diff --git a/src/v0/destinations/google_adwords_enhanced_conversions/config.js b/src/v0/destinations/google_adwords_enhanced_conversions/config.js
@@ -1,8 +1,8 @@
 const { getMappingConfig } = require('../../util');
 
-const API_VERSION = 'v17';
+const API_VERSION = 'v18';
 
-const BASE_ENDPOINT = 'https://googleads.googleapis.com/v17/customers';
+const BASE_ENDPOINT = `https://googleads.googleapis.com/${API_VERSION}/customers`;
 
 const CONFIG_CATEGORIES = {
   TRACK_CONFIG: { type: 'track', name: 'trackConfig' },

diff --git a/src/v0/destinations/google_adwords_offline_conversions/config.js b/src/v0/destinations/google_adwords_offline_conversions/config.js
@@ -1,6 +1,6 @@
 const { getMappingConfig } = require('../../util');
 
-const API_VERSION = 'v17';
+const API_VERSION = 'v18';
 
 const BASE_ENDPOINT = `https://googleads.googleapis.com/${API_VERSION}/customers/:customerId`;
 
@@ -65,4 +65,5 @@ module.exports = {
   trackAddStoreAddressConversionsMapping:
     MAPPING_CONFIG[CONFIG_CATEGORIES.TRACK_STORE_ADDRESS_IDENTIFIER.name],
   consentConfigMap,
+  API_VERSION,
 };
diff --git a/src/v0/destinations/google_adwords_offline_conversions/utils.test.js b/src/v0/destinations/google_adwords_offline_conversions/utils.test.js
@@ -6,6 +6,8 @@ const {
   getCallConversionPayload,
 } = require('./utils');
 
+const API_VERSION = 'v18';
+
 const getTestMessage = () => {
   let message = {
     event: 'testEventName',
@@ -163,7 +165,7 @@ describe('getExisitingUserIdentifier util tests', () => {
 describe('getClickConversionPayloadAndEndpoint util tests', () => {
   it('getClickConversionPayloadAndEndpoint flow check when default field identifier is present', () => {
     let expectedOutput = {
-      endpoint: 'https://googleads.googleapis.com/v17/customers/9625812972:uploadClickConversions',
+      endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/9625812972:uploadClickConversions`,
       payload: {
         conversions: [
           {
@@ -193,7 +195,7 @@ describe('getClickConversionPayloadAndEndpoint util tests', () => {
     delete fittingPayload.traits.email;
     delete fittingPayload.properties.email;
     let expectedOutput = {
-      endpoint: 'https://googleads.googleapis.com/v17/customers/9625812972:uploadClickConversions',
+      endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/9625812972:uploadClickConversions`,
       payload: {
         conversions: [
           {
@@ -225,7 +227,7 @@ describe('getClickConversionPayloadAndEndpoint util tests', () => {
     delete fittingPayload.traits.phone;
     delete fittingPayload.properties.email;
     let expectedOutput = {
-      endpoint: 'https://googleads.googleapis.com/v17/customers/9625812972:uploadClickConversions',
+      endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/9625812972:uploadClickConversions`,
       payload: {
         conversions: [
           {
@@ -263,7 +265,7 @@ describe('getClickConversionPayloadAndEndpoint util tests', () => {
       },
     ];
     let expectedOutput = {
-      endpoint: 'https://googleads.googleapis.com/v17/customers/9625812972:uploadClickConversions',
+      endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/9625812972:uploadClickConversions`,
       payload: {
         conversions: [
           {

diff --git a/src/v0/destinations/google_adwords_remarketing_lists/config.js b/src/v0/destinations/google_adwords_remarketing_lists/config.js
@@ -1,6 +1,6 @@
 const { getMappingConfig } = require('../../util');
 
-const API_VERSION = 'v17';
+const API_VERSION = 'v18';
 
 const BASE_ENDPOINT = `https://googleads.googleapis.com/${API_VERSION}/customers`;
 const CONFIG_CATEGORIES = {

diff --git a/test/integrations/destinations/google_adwords_enhanced_conversions/dataDelivery/business.ts b/test/integrations/destinations/google_adwords_enhanced_conversions/dataDelivery/business.ts
@@ -4,7 +4,8 @@ import {
   generateProxyV1Payload,
 } from '../../../testUtils';
 import { ProxyV1TestData } from '../../../testTypes';
-import { API_VERSION } from '../../../../../src/v0/destinations/google_adwords_enhanced_conversions/config';
+
+const API_VERSION = 'v18';
 
 const headers = {
   Authorization: 'Bearer abcd1234',

diff --git a/test/integrations/destinations/google_adwords_enhanced_conversions/dataDelivery/oauth.ts b/test/integrations/destinations/google_adwords_enhanced_conversions/dataDelivery/oauth.ts
@@ -1,4 +1,5 @@
-import { API_VERSION } from '../../../../../src/v0/destinations/google_adwords_enhanced_conversions/config';
+const API_VERSION = 'v18';
+
 import {
   generateProxyV1Payload,
   generateProxyV0Payload,

diff --git a/test/integrations/destinations/google_adwords_enhanced_conversions/network.ts b/test/integrations/destinations/google_adwords_enhanced_conversions/network.ts
@@ -1,4 +1,5 @@
-import { API_VERSION } from '../../../../src/v0/destinations/google_adwords_enhanced_conversions/config';
+const API_VERSION = 'v18';
+
 export const networkCallsData = [
   {
     httpReq: {

diff --git a/test/integrations/destinations/google_adwords_enhanced_conversions/processor/data.ts b/test/integrations/destinations/google_adwords_enhanced_conversions/processor/data.ts
@@ -1,4 +1,4 @@
-import { API_VERSION } from '../../../../../src/v0/destinations/google_adwords_enhanced_conversions/config';
+const API_VERSION = 'v18';
 export const data = [
   {
     name: 'google_adwords_enhanced_conversions',

diff --git a/test/integrations/destinations/google_adwords_enhanced_conversions/router/data.ts b/test/integrations/destinations/google_adwords_enhanced_conversions/router/data.ts
@@ -1,3 +1,5 @@
+const API_VERSION = 'v18';
+
 const events = [
   {
     metadata: {
@@ -657,8 +659,7 @@ export const data = [
                   JSON_ARRAY: {},
                   XML: {},
                 },
-                endpoint:
-                  'https://googleads.googleapis.com/v17/customers/1234567890:uploadConversionAdjustments',
+                endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/1234567890:uploadConversionAdjustments`,
                 files: {},
                 headers: {
                   Authorization: 'Bearer abcd1234',
@@ -828,8 +829,7 @@ export const data = [
                   JSON_ARRAY: {},
                   XML: {},
                 },
-                endpoint:
-                  'https://googleads.googleapis.com/v17/customers/1234567890:uploadConversionAdjustments',
+                endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/1234567890:uploadConversionAdjustments`,
                 files: {},
                 headers: {
                   Authorization: 'Bearer abcd1234',

diff --git a/test/integrations/destinations/google_adwords_offline_conversions/dataDelivery/business.ts b/test/integrations/destinations/google_adwords_offline_conversions/dataDelivery/business.ts
@@ -4,6 +4,8 @@ import {
   generateProxyV1Payload,
 } from '../../../testUtils';
 
+const API_VERSION = 'v18';
+
 const transactionAttribute = {
   CUSTOM_KEY: 'CUSTOM_VALUE',
   currency_code: 'INR',
@@ -234,8 +236,7 @@ export const testScenariosForV0API = [
           headers: headers.header1,
           params: params.param1,
           JSON: invalidArgumentRequestPayload,
-          endpoint:
-            'https://googleads.googleapis.com/v17/customers/11122233331/offlineUserDataJobs',
+          endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/11122233331/offlineUserDataJobs`,
         }),
         method: 'POST',
       },
@@ -309,7 +310,7 @@ export const testScenariosForV0API = [
           headers: headers.header1,
           params: params.param1,
           JSON: validRequestPayload1,
-          endpoint: 'https://googleads.googleapis.com/v17/customers/1112223333/offlineUserDataJobs',
+          endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/1112223333/offlineUserDataJobs`,
         }),
         method: 'POST',
       },
@@ -349,8 +350,7 @@ export const testScenariosForV0API = [
           headers: headers.header2,
           params: params.param2,
           JSON: validRequestPayload2,
-          endpoint:
-            'https://googleads.googleapis.com/v17/customers/1234567891:uploadClickConversions',
+          endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/1234567891:uploadClickConversions`,
         }),
         method: 'POST',
       },
@@ -399,8 +399,7 @@ export const testScenariosForV0API = [
           headers: headers.header2,
           params: params.param3,
           JSON: validRequestPayload2,
-          endpoint:
-            'https://googleads.googleapis.com/v17/customers/1234567891:uploadClickConversions',
+          endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/1234567891:uploadClickConversions`,
         }),
         method: 'POST',
       },
@@ -452,8 +451,7 @@ export const testScenariosForV1API = [
             headers: headers.header1,
             params: params.param1,
             JSON: invalidArgumentRequestPayload,
-            endpoint:
-              'https://googleads.googleapis.com/v17/customers/11122233331/offlineUserDataJobs',
+            endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/11122233331/offlineUserDataJobs`,
           },
           metadataArray,
         ),
@@ -499,8 +497,7 @@ export const testScenariosForV1API = [
             headers: headers.header1,
             params: params.param1,
             JSON: validRequestPayload1,
-            endpoint:
-              'https://googleads.googleapis.com/v17/customers/1112223333/offlineUserDataJobs',
+            endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/1112223333/offlineUserDataJobs`,
           },
           metadataArray,
         ),
@@ -544,8 +541,7 @@ export const testScenariosForV1API = [
             headers: headers.header2,
             params: params.param2,
             JSON: validRequestPayload2,
-            endpoint:
-              'https://googleads.googleapis.com/v17/customers/1234567891:uploadClickConversions',
+            endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/1234567891:uploadClickConversions`,
           },
           metadataArray,
         ),
@@ -590,8 +586,7 @@ export const testScenariosForV1API = [
             headers: headers.header2,
             params: params.param3,
             JSON: validRequestPayload2,
-            endpoint:
-              'https://googleads.googleapis.com/v17/customers/1234567891:uploadClickConversions',
+            endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/1234567891:uploadClickConversions`,
           },
           metadataArray,
         ),
@@ -636,8 +631,7 @@ export const testScenariosForV1API = [
             headers: headers.header2,
             params: params.param4,
             JSON: notAllowedToAccessFeatureRequestPayload,
-            endpoint:
-              'https://googleads.googleapis.com/v17/customers/1234567893:uploadClickConversions',
+            endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/1234567893:uploadClickConversions`,
           },
           metadataArray,
         ),

diff --git a/test/integrations/destinations/google_adwords_offline_conversions/dataDelivery/oauth.ts b/test/integrations/destinations/google_adwords_offline_conversions/dataDelivery/oauth.ts
@@ -4,6 +4,8 @@ import {
   generateProxyV0Payload,
 } from '../../../testUtils';
 
+const API_VERSION = 'v18';
+
 const commonHeaders = {
   Authorization: 'Bearer abcd1234',
   'Content-Type': 'application/json',
@@ -95,7 +97,7 @@ export const v0oauthScenarios = [
       request: {
         body: generateProxyV0Payload({
           ...commonRequestParameters,
-          endpoint: 'https://googleads.googleapis.com/v17/customers/customerid/offlineUserDataJobs',
+          endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/customerid/offlineUserDataJobs`,
         }),
         method: 'POST',
       },
@@ -138,7 +140,7 @@ export const v0oauthScenarios = [
       request: {
         body: generateProxyV0Payload({
           ...commonRequestParameters,
-          endpoint: 'https://googleads.googleapis.com/v17/customers/1234/offlineUserDataJobs',
+          endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/1234/offlineUserDataJobs`,
         }),
         method: 'POST',
       },
@@ -183,8 +185,7 @@ export const v1oauthScenarios = [
         body: generateProxyV1Payload(
           {
             ...commonRequestParameters,
-            endpoint:
-              'https://googleads.googleapis.com/v17/customers/customerid/offlineUserDataJobs',
+            endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/customerid/offlineUserDataJobs`,
           },
           metadataArray,
         ),
@@ -230,7 +231,7 @@ export const v1oauthScenarios = [
         body: generateProxyV1Payload(
           {
             ...commonRequestParameters,
-            endpoint: 'https://googleads.googleapis.com/v17/customers/1234/offlineUserDataJobs',
+            endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/1234/offlineUserDataJobs`,
           },
           metadataArray,
         ),
@@ -281,8 +282,7 @@ export const v1oauthScenarios = [
               'developer-token': 'ijkl91011',
               'login-customer-id': 'logincustomerid',
             },
-            endpoint:
-              'https://googleads.googleapis.com/v17/customers/customerid/offlineUserDataJobs',
+            endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/customerid/offlineUserDataJobs`,
           },
           metadataArray,
         ),
@@ -353,8 +353,7 @@ export const v1oauthScenarios = [
               'developer-token': 'ijkl91011',
               'login-customer-id': 'logincustomerid',
             },
-            endpoint:
-              'https://googleads.googleapis.com/v17/customers/customerid/offlineUserDataJobs',
+            endpoint: `https://googleads.googleapis.com/${API_VERSION}/customers/customerid/offlineUserDataJobs`,
           },
           metadataArray,
         ),