Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update test cases for branch #3955

Merged
merged 5 commits into from
Jan 3, 2025
Merged

Conversation

ItsSudip
Copy link
Member

What are the changes introduced in this PR?

We are updating branch test cases with types.

What is the related Linear task?

Resolves INT-2997

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@ItsSudip ItsSudip requested review from sivashanmukh and a team as code owners December 30, 2024 12:41
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.72%. Comparing base (9d6a002) to head (64030dd).
Report is 11 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3955      +/-   ##
===========================================
+ Coverage    90.50%   90.72%   +0.22%     
===========================================
  Files          620      617       -3     
  Lines        32518    32414     -104     
  Branches      7710     7702       -8     
===========================================
- Hits         29429    29409      -20     
+ Misses        2865     2749     -116     
- Partials       224      256      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from fix.branch to develop January 3, 2025 05:55
@ItsSudip ItsSudip requested a review from a team as a code owner January 3, 2025 05:55
yashasvibajpai
yashasvibajpai previously approved these changes Jan 3, 2025
@ItsSudip ItsSudip merged commit b3280ad into develop Jan 3, 2025
27 checks passed
@ItsSudip ItsSudip deleted the chore.update_test_cases branch January 3, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants