Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor adjust source to webhook v2 #3989

Closed
wants to merge 8 commits into from

Conversation

vinayteki95
Copy link
Contributor

What are the changes introduced in this PR?

  • Refactor of adjust source to utitlise the lasted webhook V2 contract with server. This new contract has the entire request structure from which query_parameters can be used to prepare the payload.
  • Refactored the v0 source as well to isolate core logic from payload preparation logic.

What is the related Linear task?

Resolves INT-3130

Please explain the objectives of your changes below

This source is refactored to cleanly use the new webhook v2 specification for information beyond request body.

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

No

Any new dependencies introduced with this change?

No

Any new generic utility introduced or modified. Please explain the changes.

No

Any technical or performance related pointers to consider with the change?

Make small optimisations by cleaning likes like lodash.deepcopy with no effect.

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@vinayteki95 vinayteki95 requested review from a team and sivashanmukh as code owners January 17, 2025 13:31
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 98.27586% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.09%. Comparing base (68497f9) to head (9faef2e).
Report is 25 commits behind head on develop.

Files with missing lines Patch % Lines
src/sources/adjust/transform.js 93.75% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3989      +/-   ##
===========================================
+ Coverage    91.00%   91.09%   +0.09%     
===========================================
  Files          629      629              
  Lines        32824    32833       +9     
  Branches      7788     7788              
===========================================
+ Hits         29871    29909      +38     
+ Misses        2734     2674      -60     
- Partials       219      250      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

koladilip
koladilip previously approved these changes Jan 22, 2025
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@vinayteki95 vinayteki95 deleted the chore.refactor-source-adjust-to-v2 branch February 14, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants