Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 4 TODO's from the list #402

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

matu6968
Copy link

@matu6968 matu6968 commented Mar 1, 2025

So far i have only tested and know it is working for these TODO's:

  • Loading animation (spinner)
  • Resolve design glitches/styling/theming (immersive mode, window insets for holes/notches/corners)
  • Bundle demo animations/games:
    The UI for this looks like:
    image
  • History and favorites
    The UI for those look like:
    image
    image

matu6968 added 2 commits March 1, 2025 16:25
…ing/theming, bundle demo animations/games, History, favorites, other flair...?)
@torokati44
Copy link
Member

Thanks a lot for your interest and contribution, these changes look great!

Could you perhaps submit each of the 4 TODO items as separate PRs?
That way, the ones that don't break the tests could be pulled in quickly, while the issues with the rest are resolved.

@matu6968
Copy link
Author

matu6968 commented Mar 3, 2025

Thanks a lot for your interest and contribution, these changes look great!

Could you perhaps submit each of the 4 TODO items as separate PRs? That way, the ones that don't break the tests could be pulled in quickly, while the issues with the rest are resolved.

Sorry, but i did these 4 TODO's in a single go and may not be able to split them into separate PR's, but if i can then i would try to split them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants