Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Madrid.rb sponsors #1105

Merged
merged 1 commit into from
Jan 25, 2025
Merged

chore: Update Madrid.rb sponsors #1105

merged 1 commit into from
Jan 25, 2025

Conversation

josepegea
Copy link
Collaborator

Since we revived the Madrid.rb group by the end of last year, we are updating the sponsors

@josepegea josepegea changed the title Update Madrid.rb sponsors chore: Update Madrid.rb sponsors Jan 25, 2025
@salzig salzig merged commit d534c99 into master Jan 25, 2025
1 check passed
@salzig salzig deleted the madridrb-update-sponsors branch January 25, 2025 12:09
@salzig
Copy link
Collaborator

salzig commented Jan 25, 2025

damn it, I'm still not used to some of the areas of this project. Sponsor images are missing. Could you provide another PR with those?

@josepegea
Copy link
Collaborator Author

josepegea commented Jan 25, 2025 via email

@phoet
Copy link
Member

phoet commented Jan 25, 2025

i decided against adding this to the admin part, so that the project did not have to pay for file storage. sponsor images are changed very rarely, so i think this works good enough.

@salzig
Copy link
Collaborator

salzig commented Jan 25, 2025

I'm ok with it, or more I think you're right about it. Maybe I add a test that verifies every mentioned sponsor image is actually in this repository.

@josepegea
Copy link
Collaborator Author

Such a test would be cool, but, indeed, it was just my sleepy head forgetting to add the already created images to the commit. It's very easy to notice once you go to see the result and the logos aren't there

@salzig
Copy link
Collaborator

salzig commented Jan 25, 2025

#1107 lets hope it doesn't happen again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants