Migrate from Bootstrap 4.5 to Bootstrap 5.3 #1129
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salzig
force-pushed
the
bootstrap-5-migration
branch
2 times, most recently
from
df09b1a to
a7a819f
Compare
| span.badge.badge-card-header.badge-organizer | ||
| = fa_icon('star', text: 'Organizer') | ||
| span.position-absolute.ms-5.top-0.translate-middle.badge.p-2.text-bg-light.border.border-light.rounded-border | ||
| = fa_icon "star", text: "Organizer" |
There was a problem hiding this comment.
why the change from ' to "? Don't we have a rubocop rule for that?
|
After Checking out and testing locally I see that there are some flaws with the new Bootstrap.
vs
seems like that it needs to be just fine adjustments |
salzig
force-pushed
the
bootstrap-5-migration
branch
from
a7a819f to
4fb6696
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what can possibly go wrong?