-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update the version of chromadb client to 1.10.3 that is compatible with the latest Docker version of chroma (0.6.3) #1608
base: main
Are you sure you want to change the base?
Conversation
@my8bit is attempting to deploy a commit to the LlamaIndex Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 8998d36 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -210,7 +210,6 @@ export class ChromaVectorStore extends BaseVectorStore { | |||
QueryRecordsParams | |||
>{ | |||
queryEmbeddings: query.queryEmbedding ?? undefined, | |||
queryTexts: query.queryStr ?? undefined, | |||
nResults: query.similarityTopK, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new client is requiring only one prop so I choose to pass the queryEmbeddings
only as we already have them at this stage.
@@ -43,7 +43,7 @@ | |||
"dependencies": { | |||
"@llamaindex/core": "workspace:*", | |||
"@llamaindex/env": "workspace:*", | |||
"chromadb": "1.9.2", | |||
"chromadb": "1.10.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as an alternative approach the latest version (as *) can be specified as well
"chromadb": "*",
"chromadb-default-embed": "*"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @my8bit - that looks great
@llamaindex/autotool
@llamaindex/community
@llamaindex/cloud
@llamaindex/core
@llamaindex/experimental
llamaindex
@llamaindex/env
@llamaindex/node-parser
@llamaindex/readers
@llamaindex/wasm-tools
@llamaindex/workflow
@llamaindex/anthropic
@llamaindex/clip
@llamaindex/deepinfra
@llamaindex/groq
@llamaindex/huggingface
@llamaindex/ollama
@llamaindex/openai
@llamaindex/portkey-ai
@llamaindex/replicate
@llamaindex/vercel
@llamaindex/vllm
commit: |
The version
1.9.2
that is currently in the repo is not compatible with the latest chroma Docker image (0.6.3)Steps to reproduce:
then run the example from
examples/chromadb
side note: first there will be an error regarding the incorrect path do the
data.csv
file. This fix included to the MR as well, and after that the actual issue:and from Docker image
with the update version from this PR it works as expected.
I didn't include the changeset as was not sure if this should trigger the
major
bump, so I'd like to ask your guidance on that