feat: intelligent comment splits #5786
Open
+399
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ross Strickland <[email protected]>
github-actions
bot
added
provider/azuredevops
go
|
@jamengual - I'm not seeing a clear issue with the tests. Also, are the image build from branches available on ghcr or elsewhere? |
I created a PR to fix the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Handle closure for code/detail/etc blocks appropriately when splitting VCS comments.
why
The logic for splitting comments has always assumed it would happen in the middle of a code block, which is not always the case, leading to poor UX.
tests
Updated the old tests and added new ones to verify behavior.
references
closes #2240