Skip to content

fix: clean up workflow log streams when pullrequest is closed/merged #5798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: clean up workflow log streams when pullrequest is closed/merged #5798

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions server/events/pull_closed_executor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,14 @@ func (p *PullClosedExecutor) CleanUpPull(logger logging.SimpleLogging, repo mode
}
Copy link

@YounisDany YounisDany Sep 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

التغييرات واضحة، إضافة تنظيف Log Streams ممتازة للحفاظ على الموارد. 👌

p.LogStreamResourceCleaner.CleanUp(jobContext)
}

// Clean up log streams associated with the pull request workflow.
jobContext := jobs.PullInfo{
PullNum: pull.Num,
Repo: pull.BaseRepo.Name,
RepoFullName: pull.BaseRepo.FullName,
}
p.LogStreamResourceCleaner.CleanUp(jobContext)
}

if err := p.WorkingDir.Delete(logger, repo, pull); err != nil {
Expand Down
Loading