chore: Create new workspace package #5881
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Move workspace-related types from
server/eventsto new subpackageserver/events/workspace.Moved:
WorkingDirinterfaceWorkingDirLockerinterfaceFileWorkspacestructGithubAppWorkingDirstructwhy
I noticed that there were two different mocks being created for
WorkingDir: one inevents/mocks/and another in theeventspackage itself (mock_workingdir_test.go). It is the only mock in the project which is written into a non-mock package, leading to oddities like in #5800 where it is formatted differently (because we have different formatting rules for mock and non-mock).The duplicate existed because
project_command_builder_internal_test.go(an internal test inpackage events) needed to import the mock, but importingevents/mockswould create an import cycle (events→events/mocks→events).This was an indication that the workspace code was getting big enough to be its own package. Moving it to a subpackage breaks the import cycle while keeping the code organized.
tests
go build ./...go test ./server/events ./server/controllers/... -shortgolangci-lint runreferences
N/A