feat: allow setting service.SessionAffinity #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essionAffinityConfig Signed-off-by: Brian Long <[email protected]>
Signed-off-by: Brian Long <[email protected]>
brilong
force-pushed
the
service-affinity
branch
from
fee3d47 to
ef5c8a6
Compare
Member
|
Hi @brilong, thanks for the feature! This is a nice and clean PR ✨ Can you just rebase and bump the chart again please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Expose and template
service.sessionAffinity(e.g.,ClientIP) andservice.sessionAffinityConfig(e.g.,clientIP.timeoutSeconds) along with optionalservice.internalTrafficPolicy(Cluster/Local), all defaulting to null for backward compatibility.why
In multi-replica environments, providing these values enables opt-in stickiness so browsers consistently reach the same pod.
tests
make unit-test-run-atlantisruns cleanly with new service_affinity_test.yaml test.references
Closes #499