refactor: apply linting fixes and add type annotations#60
Open
hasan613 wants to merge 2 commits intoruslansenatorov:devfrom
Open
refactor: apply linting fixes and add type annotations#60hasan613 wants to merge 2 commits intoruslansenatorov:devfrom
hasan613 wants to merge 2 commits intoruslansenatorov:devfrom
Conversation
hasan613
changed the title
hasan613
force-pushed
the
feat-calc-fix
branch
from
413f856 to
73056bc
Compare
hasan613
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что изменено:
- Исправлена логическая ошибка в функции calculator: теперь переменная operation считывается как строка, а не int, что позволило корректно сравнивать её со знаками операций.
- Добавлены аннотации типов (Type Annotations) для функции calculator для прохождения проверки mypy.
- Добавлены строки документации (docstrings) для модуля и функции согласно требованиям pylint.
- Код отформатирован инструментами black и docformatter.
Почему это важно:
- Это исправляет падение программы при вводе математических знаков.
- Приводит код к стандарту PEP 8, делая его более читаемым и поддерживаемым.
closes #61