Correct DoH base64 alphabet to base64url not base64 #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DoH is supposed to require the base64url encoding of the DNS request, but our encoder was actually using classic base64. While this is incorrect, it appears many (most?) DoH resolvers will actually accept base64 just fine. Still, best to swap for the correct alphabet, which we do here. Fixes rust-bitcoin#12
|
Also pushed a doc fix for #11. |
benthecarman
approved these changes
Sep 19, 2025
|
Also (hopefully) marginally improved test robustness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DoH is supposed to require the base64url encoding of the DNS request, but our encoder was actually using classic base64. While this is incorrect, it appears many (most?) DoH resolvers will actually accept base64 just fine.
Still, best to swap for the correct alphabet, which we do here.
Fixes #12