Skip to content

Conversation

vthib
Copy link

@vthib vthib commented Oct 19, 2025

Anstyle crates are the only dependencies that are still pulling the windows-sys 0.61 on my projects.

There is an existing PR for it by the renovate bot:
#272 , but I figured i'd provide a PR that should be pass the CI to be easily mergeable.

This update requires a bump of MSRV to 1.71

vthib added 2 commits October 19, 2025 22:10
windows-sys 0.61 requires windows-link 0.2.1 which
requires rustc 1.71
@vthib vthib force-pushed the update-windows-sys-0.61 branch from 86fe278 to 2753d06 Compare October 19, 2025 20:14
@epage
Copy link
Collaborator

epage commented Oct 20, 2025

This update requires a bump of MSRV to 1.71

We're not doing an MSRV bump at this time which is why #272 is still open

@epage epage closed this Oct 20, 2025
@vthib
Copy link
Author

vthib commented Oct 20, 2025

Can you elaborate on why a bump from 1.66 (released in december 2022) to 1.71 (released in july 2023) is not acceptable? What is the MSRV goal of this project, that is how long ago should a version have been released to be acceptable as a MSRV?

@epage
Copy link
Collaborator

epage commented Oct 20, 2025

I don't really have a solid policy atm. anstyle is meant to be a low level, fundamental piece of software for easy integration with other libraries. While anstream is higher level`, it is meant to be fairly applicable. This exists in a shared workspace where I tried to keep the MSRV the same.

Looking at our top direct dependents

We already excluded Winnow with the 1.66 bump.

Other important deps include:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants