-
Notifications
You must be signed in to change notification settings - Fork 177
Refactor VectActive to Vector and pass it to DefaultHandler.
#437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
(rust-highfive has picked a reviewer for you, use r? to override) |
ef6fb9b to
fd04623
Compare
0b207d0 to
75c8227
Compare
75c8227 to
53c40eb
Compare
|
@thalesfragoso, ping. |
|
Sorry we dropped this one. It looks OK to me, but it's a breaking change. @rust-embedded/arm how do we feel about breaking changes in cortex-m / cortex-m-rt 0.8? |
| } | ||
|
|
||
| impl TryFrom<i8> for Exception { | ||
| type Error = i8; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for returning the argument back on error?
I don't have a problem with breaking changes in 0.8 per se, but breaking both c-m and c-m-rt at the same time in an inter-dependent way will make upgrading even harder than it already is, so the change would have to be really well motivated and I don't really understand the motivation here. |
Changes:
Vector::map_interruptfunction to allow mapping theVector::Interruptvariant to e.g. a HAL's interrupt type.SCB::vect_pendingfunction for getting the pending vector, if any.