Fix dimable_name regular expression #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex for dimable names wasn't anchoring the entire expression on the start and end of lines, just the first and last optional matches.
burrbull
approved these changes
Jun 2, 2020
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 2, 2020
122: Fix dimable_name regular expression r=burrbull a=gkelly The regex for dimable names wasn't anchoring the entire expression on the start and end of lines, just the first and last optional matches. Co-authored-by: Garret Kelly <[email protected]>
|
Build failed: |
https://travis-ci.org/github/rust-embedded/svd/jobs/693897919, the failure seems unrelated to this change. Not sure how to diagnose the actual issue here off hand. |
|
Looks like we need up minimal supported Rust version to 1.36 |
|
cc @therealprof |
|
crossbeam-rs/crossbeam#504 maybe related? |
|
Opened #123 to bump MSRV. |
Closed
|
bors r=burrbull |
bors bot
added a commit
that referenced
this pull request
Jun 2, 2020
122: Fix dimable_name regular expression r=burrbull a=gkelly The regex for dimable names wasn't anchoring the entire expression on the start and end of lines, just the first and last optional matches. Co-authored-by: Garret Kelly <[email protected]>
|
Build failed: |
|
Still working on the CI in #124. |
|
bors r=burrbull |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex for dimable names wasn't anchoring the entire expression on
the start and end of lines, just the first and last optional matches.