Skip to content

Conversation

glaeqen
Copy link

@glaeqen glaeqen commented Sep 15, 2025

CMSIS-SVD repository was moved plus git:// makes the git command hang.

Recent
change
in the Rust platform in NixOS/nixpkgs prevents a user from packaging a Rust program using crates from this repository to be used as dependencies as it forces their submodules to be checked out, regardless of the submodule.*.update setting.

CMSIS-SVD repository was moved plus git:// makes the git command hang.

[Recent
change](NixOS/nixpkgs@5cd869c)
in the Rust platform in `NixOS/nixpkgs` prevents a user from
packaging a Rust program using crates from this repository to be
used as dependencies as it forces their submodules to be checked out,
regardless of the `submodule.*.update` setting.
@glaeqen glaeqen requested a review from a team as a code owner September 15, 2025 14:51
@glaeqen
Copy link
Author

glaeqen commented Sep 15, 2025

Alternative: can we just remove cmsis-svd as a submodule altogether? The only place it is used at is the generate-tests.sh that is not even a part of any pipeline as far as I can see. We could just clone the repo in the script instead

adamgreig
adamgreig previously approved these changes Sep 30, 2025
@adamgreig
Copy link
Member

Alternative: can we just remove cmsis-svd as a submodule altogether? The only place it is used at is the generate-tests.sh that is not even a part of any pipeline as far as I can see. We could just clone the repo in the script instead

I'm fine with either, but I'll merge this for now and if you would like to make a PR removing it and instead cloning it in the script please go ahead.

@adamgreig adamgreig enabled auto-merge September 30, 2025 18:35
@adamgreig
Copy link
Member

Ah, it looks like CI is failing on latest stable Rust due to elided lifetime warnings, stopping this from merging.

@datdenkikniet
Copy link
Contributor

Will make a PR to fix the warnings.

auto-merge was automatically disabled September 30, 2025 20:06

Head branch was pushed to by a user without write access

@glaeqen
Copy link
Author

glaeqen commented Sep 30, 2025

I decided to do it all at once in this PR because I realized that URL I switched to leads to a wrong repository anyway (should have been cmsis-svd-data, not cmsis-svd) and I figured it's maybe worth a shot to make this script useful, maybe even enable it in the CI. But:

Script works and generates Rust files in a way it was, I think, intended. But I'm not sure how they should be used, svd-tests does not try to include the generated root cmsis.rs file to make cargo test operational, not sure how these tests were supposed to be run to begin with.

Maybe it's enough for this PR.

@adamgreig
Copy link
Member

Thanks! I think if you rebase onto master it will pull in #295 to fix the CI.

It looks like #219 is related but was never merged.

@glaeqen
Copy link
Author

glaeqen commented Sep 30, 2025

Forgot about the rebase, right. I merged master into HEAD, I hope that's also okay.

It looks like #219 is related but was never merged.

Interesting, it might be worth looking into but maybe as a separate PR or just by reviving the old one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants