-
Notifications
You must be signed in to change notification settings - Fork 63
Make the URL for the submodule valid #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
CMSIS-SVD repository was moved plus git:// makes the git command hang. [Recent change](NixOS/nixpkgs@5cd869c) in the Rust platform in `NixOS/nixpkgs` prevents a user from packaging a Rust program using crates from this repository to be used as dependencies as it forces their submodules to be checked out, regardless of the `submodule.*.update` setting.
Alternative: can we just remove cmsis-svd as a submodule altogether? The only place it is used at is the |
I'm fine with either, but I'll merge this for now and if you would like to make a PR removing it and instead cloning it in the script please go ahead. |
Ah, it looks like CI is failing on latest stable Rust due to elided lifetime warnings, stopping this from merging. |
Will make a PR to fix the warnings. |
Head branch was pushed to by a user without write access
I decided to do it all at once in this PR because I realized that URL I switched to leads to a wrong repository anyway (should have been Script works and generates Rust files in a way it was, I think, intended. But I'm not sure how they should be used, Maybe it's enough for this PR. |
Forgot about the rebase, right. I merged master into HEAD, I hope that's also okay.
Interesting, it might be worth looking into but maybe as a separate PR or just by reviving the old one. |
CMSIS-SVD repository was moved plus git:// makes the git command hang.
Recent
change in the Rust platform in
NixOS/nixpkgs
prevents a user from packaging a Rust program using crates from this repository to be used as dependencies as it forces their submodules to be checked out, regardless of thesubmodule.*.update
setting.