Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform field names for Interleave[Shortest] #857

Merged

Conversation

phimuemue
Copy link
Member

The two structs are similar, and this PR reflects this fact in their field names.

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f4afe79) 93.44% compared to head (d0abdfa) 93.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #857      +/-   ##
==========================================
- Coverage   93.44%   93.37%   -0.07%     
==========================================
  Files          48       48              
  Lines        6774     6778       +4     
==========================================
- Hits         6330     6329       -1     
- Misses        444      449       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Philippe-Cholet Philippe-Cholet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you applied your idea from #849 (review), thanks.

@jswrenn jswrenn added this pull request to the merge queue Jan 20, 2024
Merged via the queue into rust-itertools:master with commit 80cd096 Jan 20, 2024
@Philippe-Cholet Philippe-Cholet added this to the next milestone Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants