Do not implement ZipEq::fold (and change test)#915
Merged
Philippe-Cholet merged 1 commit intorust-itertools:masterfrom Apr 15, 2024
Merged
Do not implement ZipEq::fold (and change test)#915Philippe-Cholet merged 1 commit intorust-itertools:masterfrom
ZipEq::fold (and change test)#915Philippe-Cholet merged 1 commit intorust-itertools:masterfrom
Conversation
Member
Philippe-Cholet
left a comment
There was a problem hiding this comment.
To be honest, I did specialize the folds that felt the most promising to me but I thought this would be a win.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #915 +/- ##
==========================================
+ Coverage 94.38% 94.42% +0.03%
==========================================
Files 48 48
Lines 6665 6837 +172
==========================================
+ Hits 6291 6456 +165
- Misses 374 381 +7 ☔ View full report in Codecov by Sentry. |
Member
Philippe-Cholet
left a comment
There was a problem hiding this comment.
After changes, if you could squash commits.
f0eeb0d to
2e6c570
Compare
ZipEq::foldZipEq::fold (and change test)
Contributor
Author
|
@Philippe-Cholet pleasure, thank you :) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #755.
I can't really think of a better way to implement this, but it still yields a regression :(