Skip to content

Update 01-01 #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 11, 2020
Merged

Update 01-01 #96

merged 4 commits into from
Oct 11, 2020

Conversation

swnakamura
Copy link

Fixes: #95

@tatsuya6502 tatsuya6502 self-requested a review September 28, 2020 01:07
@tatsuya6502 tatsuya6502 self-assigned this Sep 28, 2020
@tatsuya6502 tatsuya6502 added this to the 2018 Ed. 02 milestone Sep 28, 2020
tatsuya6502
tatsuya6502 requested changes Oct 11, 2020
View reviewed changes
Copy link
Member

@tatsuya6502 tatsuya6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビューしました。遅くなってすみません。

和訳の内容について、特に気になるとことはありませんでした。Windows language packのところは、Slackでの案をベースにして、訳注を追加してください。

@swnakamura
Copy link
Author

訳注を追加し、少しだけ勧誘文を追記しました。

tatsuya6502
tatsuya6502 approved these changes Oct 11, 2020
View reviewed changes
Copy link
Member

@tatsuya6502 tatsuya6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。レビューOKですのでマージします。

おつかれさまでした！

@tatsuya6502 tatsuya6502 merged commit c027556 into rust-lang-ja:master-ja Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatsuya6502 tatsuya6502 tatsuya6502 approved these changes

Assignees

@tatsuya6502 tatsuya6502

Labels
None yet
Projects
None yet
Milestone
2018 Ed. 02
Development

Successfully merging this pull request may close these issues.

ch01-01のアップデート
2 participants
@swnakamura @tatsuya6502