Skip to content

fix(render): Removing implicit padding with report starting with secondary title #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2025
Merged

fix(render): Removing implicit padding with report starting with secondary title #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
867261d
test: Show multi-group inconsistency
epage Sep 10, 2025
2c36f34
fix(render): No implicit padding with starting secondary groups
epage Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/renderer/render.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,11 @@ pub(crate) fn render(renderer: &Renderer, groups: Report<'_>) -> String {
max_line_num_len + 1,
);
}
if peek.is_none() && g == 0 && group_len > 1 {
if peek.is_none()
&& title_style == TitleStyle::MainHeader
&& g == 0
&& group_len > 1
{
draw_col_separator_end(
renderer,
&mut buffer,
Expand Down
50 changes: 50 additions & 0 deletions tests/formatter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,56 @@ error:
assert_data_eq!(renderer.render(input), expected_unicode);
}

#[test]
fn test_multi_group_no_snippet() {
let input = &[
Group::with_title(Level::ERROR.primary_title("the core problem")),
Group::with_title(Level::NOTE.secondary_title("more information")),
Group::with_title(Level::HELP.secondary_title("a way to fix this")),
];
let expected_ascii = str![[r#"
error: the core problem
|
note: more information
help: a way to fix this
"#]];
let renderer = Renderer::plain();
assert_data_eq!(renderer.render(input), expected_ascii);

let expected_unicode = str![[r#"
error: the core problem
╰╴
note: more information
help: a way to fix this
"#]];
let renderer = renderer.decor_style(DecorStyle::Unicode);
assert_data_eq!(renderer.render(input), expected_unicode);
}

#[test]
fn test_multi_secondary_group_no_snippet() {
let input = &[
Group::with_title(Level::ERROR.secondary_title("the core problem")),
Group::with_title(Level::NOTE.secondary_title("more information")),
Group::with_title(Level::HELP.secondary_title("a way to fix this")),
];
let expected_ascii = str![[r#"
error: the core problem
note: more information
help: a way to fix this
"#]];
let renderer = Renderer::plain();
assert_data_eq!(renderer.render(input), expected_ascii);

let expected_unicode = str![[r#"
error: the core problem
note: more information
help: a way to fix this
"#]];
let renderer = renderer.decor_style(DecorStyle::Unicode);
assert_data_eq!(renderer.render(input), expected_unicode);
}

#[test]
#[should_panic]
fn test_i26() {
Expand Down
Loading