Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: wrap text code to prevent content overflow-x #1325

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

peterpeterparker
Copy link
Contributor

@peterpeterparker peterpeterparker commented May 2, 2024

Description

While I was reading the announcement of Rust 1.78 on my mobile device, I noticed the page overflow-x was "broken".

Changes

This PR resolves the UI glitch by setting white-space: pre-wrap for the blocks of code that aren't displayed within a preformatted element.

Screenshots

Capture d’écran 2024-05-02 à 16 20 07 Capture d’écran 2024-05-02 à 16 20 49 Capture d’écran 2024-05-02 à 16 20 26 Capture d’écran 2024-05-02 à 16 21 19

@Turbo87 Turbo87 enabled auto-merge February 3, 2025 09:17
@Turbo87 Turbo87 merged commit 7e3d413 into rust-lang:master Feb 3, 2025
3 checks passed
@weihanglo
Copy link
Member

This PR breaks some styles for <code> block btw.

Before,

image

After,

image

@peterpeterparker
Copy link
Contributor Author

peterpeterparker commented Feb 5, 2025

I had forgotten about this PR—it was seven months old, and other changes likely made it outdated, as you noticed, @weihanglo. Therefore, I submitted a revert PR (#1473) and also proposed another approach to resolve the remaining issue in #1474.

@Turbo87, if you could approve the revert PR, that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants