feat: emit error if package not found within workspace #15071
Merged
+134
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @weihanglo rustbot has assigned @weihanglo. Use |
rustbot
added
A-cli
epage
reviewed
Jan 16, 2025
epage
reviewed
Jan 16, 2025
epage
reviewed
Jan 16, 2025
linyihai
force-pushed
the
workspace-warn
branch
from
28d534b to
a407aeb
Compare
linyihai
force-pushed
the
workspace-warn
branch
from
a407aeb to
03b3ca7
Compare
linyihai
force-pushed
the
workspace-warn
branch
from
03b3ca7 to
23ab2af
Compare
linyihai
changed the title
--package will be ignore if --workspace presents
epage
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Thanks!
While this turns a success case into an error case, I'm going to go ahead and merge this without an FCP because this was discussed in a Cargo team meeting where we had consensus. This was a bug that we are fixing which limits how much focus we put on compatibility. We are going straight to an error as we feel there is little value gained from a more gradual transition in this case.
If someone does have some concerns, we have nightly and beta to address them.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 8, 2025
Update cargo 14 commits in 0e3d73849ab8cbbab3ec5c65cbd555586cb21339..2928e32734b04925ee51e1ae88bea9a83d2fd451 2025-02-01 20:14:40 +0000 to 2025-02-07 16:50:22 +0000 - Simplify backtrack (rust-lang/cargo#15150) - Don't use on Solaris libc::LOCK_* which were removed from libc in ver… (rust-lang/cargo#15143) - feat: emit error if package not found within workspace (rust-lang/cargo#15071) - Make cache tracking resilient to unexpected files (rust-lang/cargo#15147) - Small resolver cleanups (rust-lang/cargo#15040) - feat: add `cargo pkgid` support for cargo-script (rust-lang/cargo#14961) - Suggest similar feature names on CLI (rust-lang/cargo#15133) - fix: Don't use "did you mean" in errors (rust-lang/cargo#15138) - Fix changelog link (rust-lang/cargo#15142) - chore(deps): update rust crate rand to 0.9.0 (rust-lang/cargo#15129) - Remove the original changelog (rust-lang/cargo#15123) - chore(deps): update rust crate gix to 0.70.0 (rust-lang/cargo#15128) - allow windows reserved names in CI (rust-lang/cargo#15135) - removed a word that was repeated (rust-lang/cargo#15136)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Fixes #12978
currently, if
--packageand--workspacepasse in the same time, the--packagewill be ignore even the package doesnt exist in the workspace, this PR regards this behavior as an errorHow should we test and review this PR?
one commit add test, one commit fixes the issue.
Additional information