Use a different lint for the fix_only_once_for_duplicates test
#15713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
epage
approved these changes
Jun 28, 2025
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Jun 29, 2025
Update cargo 7 commits in 409fed7dc1553d49cb9a8c0637d12d65571346ce..930b4f62cfcd1f0eabdb30a56d91bf6844b739bf 2025-06-23 15:55:04 +0000 to 2025-06-28 14:58:43 +0000 - Use a different lint for the `fix_only_once_for_duplicates` test (rust-lang/cargo#15713) - chore: bump to 0.91.0; update changelog (rust-lang/cargo#15710) - Add `http.proxy-cainfo` config for proxy certs (rust-lang/cargo#15374) - chore(deps): update msrv (3 versions) to v1.86 (rust-lang/cargo#15709) - chore(deps): update msrv (1 version) to v1.88 (rust-lang/cargo#15706) - Rework `cargo-test-support` & `testsuite` to use `CARGO_BIN_EXE_*` for Cargo (rust-lang/cargo#15692) - fix: Expand error messages around path dependency on `cargo package` and `cargo publish` (rust-lang/cargo#15705)
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Jun 29, 2025
Update cargo 7 commits in 409fed7dc1553d49cb9a8c0637d12d65571346ce..930b4f62cfcd1f0eabdb30a56d91bf6844b739bf 2025-06-23 15:55:04 +0000 to 2025-06-28 14:58:43 +0000 - Use a different lint for the `fix_only_once_for_duplicates` test (rust-lang/cargo#15713) - chore: bump to 0.91.0; update changelog (rust-lang/cargo#15710) - Add `http.proxy-cainfo` config for proxy certs (rust-lang/cargo#15374) - chore(deps): update msrv (3 versions) to v1.86 (rust-lang/cargo#15709) - chore(deps): update msrv (1 version) to v1.88 (rust-lang/cargo#15706) - Rework `cargo-test-support` & `testsuite` to use `CARGO_BIN_EXE_*` for Cargo (rust-lang/cargo#15692) - fix: Expand error messages around path dependency on `cargo package` and `cargo publish` (rust-lang/cargo#15705)
epage
added a commit
to epage/cargo
that referenced
this pull request
Jun 30, 2025
Inspired by rust-lang#15713
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 30, 2025
### What does this PR try to resolve? This unblocks Red CI, see [#t-cargo > Red CI: rustfix @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/246057-t-cargo/topic/Red.20CI.3A.20rustfix/near/526449337) ### How to test and review this PR? Inspired by #15713
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This PR changes the triggering
rustclint in thefix_only_once_for_duplicatestest fromunused_must_usetoforgetting_references, because we are changing in rust-lang/rust#143030 the interaction between that lint and macros.This is required as it blocking the rust PR, rust-lang/rust#143030 (comment).
How to test and review this PR?
Look at the test changes.