Skip to content

feat: in-memory only Manifest #16409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
epage merged 19 commits into from
Jan 8, 2026
Merged

feat: in-memory only Manifest #16409

epage merged 19 commits into from
Jan 8, 2026
+261 −191

Conversation

@secona
Copy link
Contributor

@secona secona commented Dec 17, 2025 •
edited
Loading

What does this PR try to resolve?

This PR supports creating an in-memory only Manifest.

Part of #16290

How to test and review this PR?

No tests should change as this is for cargo-as-a-library.

@rustbot rustbot added A-build-execution Area: anything dealing with executing the compiler A-manifest Area: Cargo.toml issues A-workspaces Area: workspaces Command-fix Command-vendor labels Dec 17, 2025
secona
secona commented Dec 17, 2025
View reviewed changes
secona
secona commented Dec 17, 2025
View reviewed changes
@secona secona mentioned this pull request Dec 17, 2025
Open
epage
epage reviewed Dec 17, 2025
View reviewed changes
@secona secona force-pushed the in-memory-manifest branch from f857ec0 to 8d25903 Compare December 17, 2025 16:21
@secona secona marked this pull request as ready for review December 17, 2025 17:06
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 17, 2025

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@secona secona force-pushed the in-memory-manifest branch from 8d25903 to c9fa22d Compare December 17, 2025 17:08
epage
epage reviewed Dec 17, 2025
View reviewed changes
@epage epage marked this pull request as draft December 17, 2025 19:13
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 17, 2025
@epage
Copy link
Contributor

epage commented Dec 17, 2025

Because of #16409 (comment), I'm moving this back to a Draft

@secona secona force-pushed the in-memory-manifest branch from c9fa22d to fae3b40 Compare December 18, 2025 23:21
secona
secona commented Dec 19, 2025
View reviewed changes
epage
epage reviewed Dec 19, 2025
View reviewed changes
epage
epage reviewed Dec 19, 2025
View reviewed changes
@secona secona force-pushed the in-memory-manifest branch from fae3b40 to 1dfa6b3 Compare December 19, 2025 20:52
@secona
refactor: optional fields in Manifest
ffa6d53 
Make `document`, `original_toml` and `contents` optional to allow
creating Manifests from in-memory data.
@secona
refactor: optional fields in ManifestErrorContext
b0ec233 
Make `contents` and `spans` optional in ManifestErrorContext to allow
disabling diagnostics.
@secona secona force-pushed the in-memory-manifest branch 4 times, most recently from 3f8a05f to 056dfae Compare December 22, 2025 08:19
@secona secona force-pushed the in-memory-manifest branch 2 times, most recently from 7d1c206 to 1dd2a8e Compare January 4, 2026 05:07
@secona secona marked this pull request as ready for review January 4, 2026 05:15
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 4, 2026
epage
epage reviewed Jan 5, 2026
View reviewed changes
epage
epage reviewed Jan 5, 2026
View reviewed changes
@secona secona force-pushed the in-memory-manifest branch from 1dd2a8e to 10e0e22 Compare January 6, 2026 00:42
secona added 12 commits January 8, 2026 00:14
@secona
fix(lints): report_feature_not_enabled
a41f228
@secona
fix(lints/unknown): handle in-memory Manifest
8d79420
@secona
refactor(lints/implicit): move function calls
6d55ff6 
Move call to `span_of_version_req` to inside `report`
@secona
refactor(lints/implicit): separate Group creation
2da08e4
@secona
fix(lints/implicit): handle in-memory Manifest
5b9da18
@secona
refactor(lints/im_a_teapot): separate report creation
9573fa3
@secona
fix(lints/im_a_teapot): handle in-memory Manifest
1f41cc8
@secona
refactor(lints/blanket): separate Group creation
9d8d268
@secona
refactor(lints/blanket): reorganize if-else
25cef94 
We need finer control on when to include snippets and when not to
@secona
fix(lints/blanket): handle in-memory Manifests
d1a2094
@secona
refactor(lints/blanket): drop unused block
677739b
@secona
fix(fix): skip default-features fix with in-memory only Manifest
cdf0891
@secona secona force-pushed the in-memory-manifest branch from 10e0e22 to cdf0891 Compare January 8, 2026 00:05
epage
epage approved these changes Jan 8, 2026
View reviewed changes
Copy link
Contributor

@epage epage left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

View changes since this review

@epage epage added this pull request to the merge queue Jan 8, 2026
Merged via the queue into rust-lang:master with commit 91f1a8a Jan 8, 2026
29 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 8, 2026
@secona secona deleted the in-memory-manifest branch January 8, 2026 18:40
@weihanglo weihanglo mentioned this pull request Jan 9, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@epage epage epage approved these changes

Assignees

@epage epage

Labels

A-build-execution Area: anything dealing with executing the compiler A-manifest Area: Cargo.toml issues A-workspaces Area: workspaces Command-fix Command-vendor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@secona @rustbot @epage