Let git decide when to run gc #16459
Open
+12
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rust-lang#4495 Let git decide when to run gc based on its own thresholds. Signed-off-by: Ojus Chugh <[email protected]>
rustbot
added
the
S-waiting-on-review
Collaborator
epage
reviewed
Jan 5, 2026
Comment on lines
-1370
to
-1371
| // Alright all else failed, let's start over. | ||
| reinitialize(repo) |
Contributor
|
This doesn't seem to be addressing the review feedback left in #4656 as called out at #4495 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Let git handle gc timing
Fixes #4495
We were counting packfiles ourselves, but git already does this
with gc --auto. No need to duplicate that logic.