Skip to content

Conversation

@smoelius
Copy link
Contributor

@smoelius smoelius commented Jan 6, 2026

This PR clears all RUSTUP_* environment variables in effort to create a "clean" environment.

However, some tests fail when RUSTUP_HOME is cleared. This PR sets RUSTUP_HOME for those tests, so that they might be further investigated.

This PR came out of #16131 (comment) and #16131 (comment).

@rustbot rustbot added A-testing-cargo-itself Area: cargo's tests S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 6, 2026

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@smoelius smoelius force-pushed the clear-rustup-env-vars branch from c052016 to d4f36b3 Compare January 6, 2026 00:14
@smoelius
Copy link
Contributor Author

smoelius commented Jan 6, 2026

I could use some help determining why the doctests are failing.

@ehuss
Copy link
Contributor

ehuss commented Jan 6, 2026

I reran the jobs. I think the runner was just flaky.

@smoelius
Copy link
Contributor Author

smoelius commented Jan 6, 2026

I'm going to try to find machines resembling the failing platforms that I can test this on.

@epage
Copy link
Contributor

epage commented Jan 7, 2026

So is the reason RUSTUP_HOME is needed for some tests is because the rustc that is in the path is the proxy and it needs to look up the actual rustc? Should we do that processing in cargo-test-support and prepend the PATH with the actual one?

@smoelius
Copy link
Contributor Author

smoelius commented Jan 8, 2026

So is the reason RUSTUP_HOME is needed for some tests is because the rustc that is in the path is the proxy and it needs to look up the actual rustc? Should we do that processing in cargo-test-support and prepend the PATH with the actual one?

I'm still investigating. I will reply within the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-testing-cargo-itself Area: cargo's tests S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants